On Tue, 6 Oct 2026 06:38:49 GMT, Robert Lichtenberger <[email protected]> 
wrote:

>> As analysed in the bug, the previousWord() method does not work correctly if 
>> at the word boundary a character is found that is neither letter nor digit.
>> This fix changes the method so that only ranges of whitespace will be 
>> skipped, resulting in correct word selection behaviour.
>> A test case has been added to TextAreaTest.
>> gradlew :controls:test --tests test.javafx.scene.control.Text*Test has been 
>> executed to ensure no regressions happen in other text related classes. No 
>> errors were reported.
>> 
>> 
>> ---------
>> - [X] I confirm that I make this contribution in accordance with the 
>> [OpenJDK Interim AI Policy](https://openjdk.org/legal/ai).
>
> Robert Lichtenberger has updated the pull request incrementally with one 
> additional commit since the last revision:
> 
>   8264588: Stylisitic improvements.

modules/javafx.controls/src/test/java/test/javafx/scene/control/behavior/TextAreaBehaviorTest.java
 line 127:

> 125: 
> 126:     @Test
> 127:     @Disabled("JDK-8393470")

oh, that's not what I meant - let's split this test in two, one with all the 
cases that pass with this PR (and may fail in the master), and one that 
contains the failing case(s).  Add `@Disabled` to the failing one.

This way we get the coverage for the fixed cases and get the test case ready 
for the followup.

-------------

PR Review Comment: https://git.openjdk.org/jfx/pull/2334#discussion_r4196947490

Reply via email to