On Wed, 7 Oct 2026 06:29:48 GMT, Robert Lichtenberger <[email protected]> wrote:
>> As analysed in the bug, the previousWord() method does not work correctly if >> at the word boundary a character is found that is neither letter nor digit. >> This fix changes the method so that only ranges of whitespace will be >> skipped, resulting in correct word selection behaviour. >> A test case has been added to TextAreaTest. >> gradlew :controls:test --tests test.javafx.scene.control.Text*Test has been >> executed to ensure no regressions happen in other text related classes. No >> errors were reported. >> >> >> --------- >> - [X] I confirm that I make this contribution in accordance with the >> [OpenJDK Interim AI Policy](https://openjdk.org/legal/ai). > > Robert Lichtenberger has updated the pull request incrementally with one > additional commit since the last revision: > > 8264588: Split test to cover current fix. A couple of test cases seem to pass on macOS, we probably should move them out of the disabled test (don't forget about initial text when moving) Also, the case of `Bug #12|3` does not work correctly in this PR - I thought the idea was to fix the most glaring cases in this PR, and leave the weird corner cases for the follow-up. modules/javafx.controls/src/test/java/test/javafx/scene/control/behavior/TextAreaBehaviorTest.java line 143: > 141: @Disabled("JDK-8393470") > 142: public void testDoubleClickSelectsCharacterClassBlocks() { > 143: execute( why is this case excluded? works on macOS. modules/javafx.controls/src/test/java/test/javafx/scene/control/behavior/TextAreaBehaviorTest.java line 170: > 168: assertEquals("3x3", control.getSelectedText()); > 169: > 170: execute( same question with this case - works on macOS. ------------- Changes requested by angorya (Reviewer). PR Review: https://git.openjdk.org/jfx/pull/2334#pullrequestreview-5448626772 PR Review Comment: https://git.openjdk.org/jfx/pull/2334#discussion_r4212211394 PR Review Comment: https://git.openjdk.org/jfx/pull/2334#discussion_r4212234411
