On Wed, 7 Oct 2026 21:44:57 GMT, Andy Goryachev <[email protected]> wrote:

>> Robert Lichtenberger has updated the pull request incrementally with one 
>> additional commit since the last revision:
>> 
>>   8264588: Split test to cover current fix.
>
> modules/javafx.controls/src/test/java/test/javafx/scene/control/behavior/TextInputControlTestBase.java
>  line 483:
> 
>> 481:             MouseEventFirer mouse = new MouseEventFirer(control);
>> 482:             for (int i = 1; i <= clickCount; i++) {
>> 483:                 mouse.fireMousePressAndRelease(i, (leading ? 
>> bounds.getMinX() : bounds.getMaxX()) - control.getLayoutBounds().getWidth() 
>> / 2, bounds.getMinY() - control.getLayoutBounds().getHeight() / 2);
> 
> clicking exactly on the character boundary (`bounds.getMinX() : 
> bounds.getMaxX()`) might backfire - perhaps we should do something like
> 
> 
> double dw = 0.1 * (bounds.getMaxX() - bounds.getMinX());
> double x = leading ? (bounds.getMinX() + dw) : (bounds.getMaxX() - dw);

Yes, I will also apply this to the y coordinate.

-------------

PR Review Comment: https://git.openjdk.org/jfx/pull/2334#discussion_r4218178603

Reply via email to