The proposal to merge lp:~patrick-zakweb/openlp/duplicate-removal-review into lp:openlp has been updated.
Description changed to: I resubmitted this request in a separate branch, because I removed the resources file to make the diff readable. This basically breaks the branch but makes it reviewable. --- This is no real merge request. I would just be grateful for some feedback on how to continue. This branch contains a logic and GUI to find, review and remove duplicate songs from the song database. The GUI can be reached via "Tools->Find Duplicate Songs". As far as I have tested everything works. There are several pain points in the code however: -No tests for the wizard. I have no real idea which parts would be best for testing (I think "everything" is not a good answer for this question :-). Probably some refactoring of the code is necessary to make it testable. -No good MVC separation for the song review widgets. Some feedback on how to improve this (hopefully without pulling off a full QItemModel subclass) would be appreciated. -I changed the wizard.py class to allow *not* adding a final progress page. I am not sure whether this is ok. ------------------------------ - Correct many whitespacing issues - Made test more standards compliant For more details, see: https://code.launchpad.net/~patrick-zakweb/openlp/duplicate-removal-review/+merge/148345 -- https://code.launchpad.net/~patrick-zakweb/openlp/duplicate-removal-review/+merge/148345 Your team OpenLP Core is requested to review the proposed merge of lp:~patrick-zakweb/openlp/duplicate-removal-review into lp:openlp. _______________________________________________ Mailing list: https://launchpad.net/~openlp-core Post to : [email protected] Unsubscribe : https://launchpad.net/~openlp-core More help : https://help.launchpad.net/ListHelp
