Review: Needs Fixing 734 === added file 'tests/functional/openlp_plugins/songs/__init__.py' 735 --- tests/functional/openlp_plugins/songs/__init__.py 1970-01-01 00:00:00 +0000 736 +++ tests/functional/openlp_plugins/songs/__init__.py 2013-02-18 20:30:34 +0000 737 @@ -0,0 +1,8 @@ 738 +import sip 739 +sip.setapi(u'QDate', 2) 740 +sip.setapi(u'QDateTime', 2) 741 +sip.setapi(u'QString', 2) 742 +sip.setapi(u'QTextStream', 2) 743 +sip.setapi(u'QTime', 2) 744 +sip.setapi(u'QUrl', 2) 745 +sip.setapi(u'QVariant', 2)
You should not need this file any longer, we committed a higher level version one or two commits back. from openlp.plugins.songs.lib.songcompare import songs_probably_equal I don't see this file in your diff :-( Lastly, if you have more than 1 GIVEN, WHEN, THEN in your test method, you need to break it up into separate tests. -- https://code.launchpad.net/~patrick-zakweb/openlp/duplicate-removal-review/+merge/149144 Your team OpenLP Core is subscribed to branch lp:openlp. _______________________________________________ Mailing list: https://launchpad.net/~openlp-core Post to : [email protected] Unsubscribe : https://launchpad.net/~openlp-core More help : https://help.launchpad.net/ListHelp
