Review: Needs Fixing Just a comment while you are re-spinnging.
Check you line lengths some must be over 120. DuplicateSongForm is passing the main_window in the constructor. Please use the Registry within the Form. The Form and Widget are in the same file. Please split into two files. Tests : having the text there is good. Could it be shorted so it still works but easier to see the differences. Hard on the eyes for us oldies ;-) -- https://code.launchpad.net/~patrick-zakweb/openlp/duplicate-removal-review/+merge/148345 Your team OpenLP Core is subscribed to branch lp:openlp. _______________________________________________ Mailing list: https://launchpad.net/~openlp-core Post to : [email protected] Unsubscribe : https://launchpad.net/~openlp-core More help : https://help.launchpad.net/ListHelp
