Review: Needs Fixing Hey,
- you should use words_separated_by_underscores instead of camelCase - After # a space should follow. And comments should be complete sentences (# This is a comment.) 590 + for author in self.song.authors: 591 + authors_text += author.display_name + ', - This would add a comma after the last author. Better do: authors_text = u', '.join([author.display_name for author in self.song.authors]) - Line 972: your doc should end with """" 973 + dsf = DuplicateSongFinder() - Don't use such abbreviations -- https://code.launchpad.net/~patrick-zakweb/openlp/duplicate-removal-review/+merge/148561 Your team OpenLP Core is subscribed to branch lp:openlp. _______________________________________________ Mailing list: https://launchpad.net/~openlp-core Post to : [email protected] Unsubscribe : https://launchpad.net/~openlp-core More help : https://help.launchpad.net/ListHelp
