Review: Needs Fixing QtCore.QObject.connect(self.errorCopyToButton, QtCore.SIGNAL(u'clicked()'), self.onErrorCopyToButtonClicked)
should be self.errorCopyToButton.clicked.connect(self.onErrorCopyToButtonClicked) There are a number of instances of this What is this for? Very non standard, self.emit(QtCore.SIGNAL(u'song_remove_button_clicked(PyQt_PyObject)'), self) 737 to 745 should not be needed. -- https://code.launchpad.net/~patrick-zakweb/openlp/duplicate-removal-review/+merge/149144 Your team OpenLP Core is subscribed to branch lp:openlp. _______________________________________________ Mailing list: https://launchpad.net/~openlp-core Post to : [email protected] Unsubscribe : https://launchpad.net/~openlp-core More help : https://help.launchpad.net/ListHelp
