Erik Trauschke writes: > http://cr.opensolaris.org/~erisch/nc_080907/
Does this pass "hg nits" using the current tool set? The changeset comments don't appear to be in the standard format, and there are still SCCS keywords here. It's unclear if it'll pass the other tests. The evaluation in the CR doesn't have much information in it about the fix; your sponsor should probably help you with that, as it'll affect the quality of review comments you get. 111,112: what is 'uint'? Suggest using the standard 'uint_t' here instead. 142: why "+1"? Port numbers can't be that long. 327-328: is this part of this fix? What does it have to do with complex port lists? (Probably needs some more information in the CR.) 335-339: why is this checked here inside the loop? Isn't the 'uport' string set just once by the command line arguments? What does checking the string on each pass buy? 337,339,408,795,826,842: nit: indenting seems to be off. 400: nit: initialization does nothing. 410: this isn't part of your change, but it doesn't look right. 's' isn't a boolean, and zero *is* a legal file descriptor. 823: computation is off by one: the number of ports in the inclusive range 'lo' to 'hi' is 'hi - lo + 1'. 840: cstyle problem: missing blank line between variable declaration and executable code. 845: just use NULL instead of casting 0. 847: not your code ... but what does '& 0xffff' accomplish here? -- James Carlson, Solaris Networking <[EMAIL PROTECTED]> Sun Microsystems / 35 Network Drive 71.232W Vox +1 781 442 2084 MS UBUR02-212 / Burlington MA 01803-2757 42.496N Fax +1 781 442 1677 _______________________________________________ opensolaris-code mailing list opensolaris-code@opensolaris.org http://mail.opensolaris.org/mailman/listinfo/opensolaris-code
