Vladimir Kotal writes: > Erik Trauschke wrote: > > Alright, I put a new webrev online: > > http://cr.opensolaris.org/~erisch/nc_080910/ > > I went through all the AIs raised by Jim and they seem to be addressed > except the following: > > 335-339: why is this checked here inside the loop? Isn't the 'uport' > string set just once by the command line arguments? What does > checking the string on each pass buy? > > - lines 333-337 in current code
I think there was an answer to this posted to the list -- the answer (as I recall) was that he needed to have a check for family != AF_UNIX, and this test block already existed for the local_listen call. I don't believe that it was functional in any way; I don't think that testing it on each pass of the loop helps anything. I grumbled and said, "ok, I guess I don't care that much." Assuming my memory is correct, I'm pretty sure it'd be easier to read with a separate check of the 'family' value outside of the loop (say as an 'else' on line 328 in the current code), but I can live with the wart if that's what the RE wants. > 410: this isn't part of your change, but it doesn't look right. 's' > isn't a boolean, and zero *is* a legal file descriptor. > > - line 408 in current code > - it seems this should be 'if (s != -1)' Yes; I would have recommended "!= -1" as well, but the current code, though perhaps a little surprising with "> -1", does the job and answers the review comment. -- James Carlson, Solaris Networking <[EMAIL PROTECTED]> Sun Microsystems / 35 Network Drive 71.232W Vox +1 781 442 2084 MS UBUR02-212 / Burlington MA 01803-2757 42.496N Fax +1 781 442 1677 _______________________________________________ opensolaris-code mailing list opensolaris-code@opensolaris.org http://mail.opensolaris.org/mailman/listinfo/opensolaris-code
