James Carlson wrote: > Vladimir Kotal writes: >> Erik Trauschke wrote:
<snip> > I think there was an answer to this posted to the list -- the answer > (as I recall) was that he needed to have a check for family != > AF_UNIX, and this test block already existed for the local_listen > call. I don't believe that it was functional in any way; I don't > think that testing it on each pass of the loop helps anything. > > I grumbled and said, "ok, I guess I don't care that much." ok, somehow I considered the comment to belong to something else. <snip> >> - it seems this should be 'if (s != -1)' > > Yes; I would have recommended "!= -1" as well, but the current code, > though perhaps a little surprising with "> -1", does the job and > answers the review comment. I would be for changing it in order not to leave potential readers wondering about the meaning. It's just a nit, though. v. _______________________________________________ opensolaris-code mailing list opensolaris-code@opensolaris.org http://mail.opensolaris.org/mailman/listinfo/opensolaris-code
