Erik Trauschke wrote:
> Alright, I put a new webrev online:
> http://cr.opensolaris.org/~erisch/nc_080910/
I went through all the AIs raised by Jim and they seem to be addressed
except the following:
335-339: why is this checked here inside the loop? Isn't the 'uport'
string set just once by the command line arguments? What does
checking the string on each pass buy?
- lines 333-337 in current code
410: this isn't part of your change, but it doesn't look right. 's'
isn't a boolean, and zero *is* a legal file descriptor.
- line 408 in current code
- it seems this should be 'if (s != -1)'
v.
_______________________________________________
opensolaris-code mailing list
opensolaris-code@opensolaris.org
http://mail.opensolaris.org/mailman/listinfo/opensolaris-code
