Erik Trauschke wrote: <snip>
>> The evaluation in the CR doesn't have much information in it about the >> fix; your sponsor should probably help you with that, as it'll affect >> the quality of review comments you get. >> > ok, right now I don't know exactly what you are talking about. I'll look > into that. I will take care of that. Bugster (our internal bug tracking system) has a field in each CR for bug fix evaluation (this field is not visible outside via bugs.opensolaris.org). This field usually contains root cause summary (in case of a bug) and breakdown of changes for that CR. <snip> >> 327-328: is this part of this fix? What does it have to do with >> complex port lists? (Probably needs some more information in the CR.) >> > > it is not part of the original CR but will prevent the app from a > segmentation fault in certain cases. If this is not the way to go, I or > my sponsor have to create a new CR for this. This is excerpt from my (now couple of weeks old) e-mail: --- > While fixing this bug I discovered another thing: > Try the following with the original netcat: nc -U -l -p 1 > It will give you a SEGFAULT cause the "host" variable is null. Good catch. I have filed CR 6707509 (nc should check -U flag usage more thoroughly) to track this. Please ask for a sponsor on the request-sponsor mailing list (so the process is followed) for that CR. --- While it's indeed trivial, it's good it was filed so it is not forgotten :) <snip> > Thanks for the comments. I will have to check what this hg comment thing > is all about. Jim already answered that, I will just add that while I can do this for you, it will better if you do this by yourself (and pass me the Mercurial bundle of the changes) after all the process related tasks are finished. Also, ad 6691168: you need to modify help() function so it can inform about the new syntax. As for the 'hg nits', make sure you have enabled Cadmium plugin (just install most recent SUNWonbld package and run hgsetup(1)). Before generating each webrev, hg nits output should be clean. v. _______________________________________________ opensolaris-code mailing list opensolaris-code@opensolaris.org http://mail.opensolaris.org/mailman/listinfo/opensolaris-code
