Alright, I put a new webrev online: http://cr.opensolaris.org/~erisch/nc_080910/
it now contains bugfixes for http://bugs.opensolaris.org/view_bug.do?bug_id=6691168 http://bugs.opensolaris.org/bugdatabase/view_bug.do?bug_id=6707509 > >> 327-328: is this part of this fix? What does it have to do with > >> complex port lists? (Probably needs some more information in the CR.) > >> > > > > it is not part of the original CR but will prevent the app from a > > segmentation fault in certain cases. If this is not the way to go, I or > > my sponsor have to create a new CR for this. > > This is excerpt from my (now couple of weeks old) e-mail: > > --- > > While fixing this bug I discovered another thing: > > Try the following with the original netcat: nc -U -l -p 1 > > It will give you a SEGFAULT cause the "host" variable is null. > > Good catch. I have filed CR 6707509 (nc should check -U flag usage more > thoroughly) to track this. Please ask for a sponsor on the > request-sponsor mailing list (so the process is followed) for that CR. > --- > > While it's indeed trivial, it's good it was filed so it is not forgotten :) I put a statement in the commit comment saying that 6707509 is included in the fix. <snip> > Also, ad 6691168: you need to modify help() function so it can inform > about the new syntax. did that > > As for the 'hg nits', make sure you have enabled Cadmium plugin (just > install most recent SUNWonbld package and run hgsetup(1)). Before > generating each webrev, hg nits output should be clean. ok, I figured it out, just wasn't aware of those functions at this time. The whole thing is now "hg nits" clean. Regards Erik _______________________________________________ opensolaris-code mailing list opensolaris-code@opensolaris.org http://mail.opensolaris.org/mailman/listinfo/opensolaris-code
