Attention is currently required from: d12fk, plaisthos. flichtenheld has posted comments on this change. ( http://gerrit.openvpn.net/c/openvpn/+/838?usp=email )
Change subject: dns: apply settings via script on unixoid systems ...................................................................... Patch Set 10: (1 comment) File doc/man-sections/script-options.rst: http://gerrit.openvpn.net/c/openvpn/+/838/comment/4e38da14_521dd7d8 : PS9, Line 258: environment values will be passed to ``--up`` and ``--down`` if no ``--dns`` > Hm, what exactly needs clarification? Okay, first of all start a new paragraph after "service there." The Windows topic should have its own paragraph. Reformulate the rest to something like: Note that DNS-related `--dhcp-option` options will not be handled by this hook. If any `--dns' option is present then DNS-related `--dhcp-option` will be ignored. Otherwise it will be given as `foreign_option` environment variable to `--up` and `--down` as in previous versions of OpenVPN. Not 100% sure this describes the correct behavior, but you can adapt it to do so. But the structure is much better to understand what is going on, IMHO. The "if no `--dns` option causes the old behavior to be overridden" is very cryptic, I think. -- To view, visit http://gerrit.openvpn.net/c/openvpn/+/838?usp=email To unsubscribe, or for help writing mail filters, visit http://gerrit.openvpn.net/settings Gerrit-Project: openvpn Gerrit-Branch: master Gerrit-Change-Id: Ifbe4ffb44d3bfcaa50adb38cacb3436fcdc71b10 Gerrit-Change-Number: 838 Gerrit-PatchSet: 10 Gerrit-Owner: d12fk <[email protected]> Gerrit-Reviewer: flichtenheld <[email protected]> Gerrit-Reviewer: plaisthos <[email protected]> Gerrit-CC: openvpn-devel <[email protected]> Gerrit-Attention: plaisthos <[email protected]> Gerrit-Attention: d12fk <[email protected]> Gerrit-Comment-Date: Thu, 06 Mar 2025 13:22:05 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: flichtenheld <[email protected]> Comment-In-Reply-To: d12fk <[email protected]> Gerrit-MessageType: comment
_______________________________________________ Openvpn-devel mailing list [email protected] https://lists.sourceforge.net/lists/listinfo/openvpn-devel
