Attention is currently required from: flichtenheld, plaisthos. d12fk has posted comments on this change. ( http://gerrit.openvpn.net/c/openvpn/+/838?usp=email )
Change subject: dns: apply settings via script on unixoid systems ...................................................................... Patch Set 12: (6 comments) File doc/man-sections/script-options.rst: http://gerrit.openvpn.net/c/openvpn/+/838/comment/b108ebbe_96e2212b : PS12, Line 246: script > No, this doesn't work. rst is very specific here, only one argument is > allowed. […] Right, even escaping the | doesn't do any good. http://gerrit.openvpn.net/c/openvpn/+/838/comment/0914df91_44ac0796 : PS12, Line 253: on > "in the order" Done http://gerrit.openvpn.net/c/openvpn/+/838/comment/5b7c6b9a_8f0f3287 : PS12, Line 258: option > `` `s `` does not work. `` `'s `` seems to work. docs suggest an escaped space instead http://gerrit.openvpn.net/c/openvpn/+/838/comment/6199f7b3_d91c8758 : PS12, Line 259: option > same Done http://gerrit.openvpn.net/c/openvpn/+/838/comment/1d4f23ec_ac1c5e61 : PS12, Line 261: ``--up`` and ``--down`` hooks for backward compatibility. > I think it is "backward*s* compatibility" Both seem to be in use, and the version without the s seems to be more common: https://en.wikipedia.org/wiki/Backward_compatibility File src/openvpn/options.c: http://gerrit.openvpn.net/c/openvpn/+/838/comment/253131df_4812f96a : PS12, Line 531: "--dns-script cmd : Run cmd as user defined dns configuration script\n" > Add the `|disable` here Done -- To view, visit http://gerrit.openvpn.net/c/openvpn/+/838?usp=email To unsubscribe, or for help writing mail filters, visit http://gerrit.openvpn.net/settings Gerrit-Project: openvpn Gerrit-Branch: master Gerrit-Change-Id: Ifbe4ffb44d3bfcaa50adb38cacb3436fcdc71b10 Gerrit-Change-Number: 838 Gerrit-PatchSet: 12 Gerrit-Owner: d12fk <he...@openvpn.net> Gerrit-Reviewer: flichtenheld <fr...@lichtenheld.com> Gerrit-Reviewer: plaisthos <arne-open...@rfc2549.org> Gerrit-CC: openvpn-devel <openvpn-devel@lists.sourceforge.net> Gerrit-Attention: plaisthos <arne-open...@rfc2549.org> Gerrit-Attention: flichtenheld <fr...@lichtenheld.com> Gerrit-Comment-Date: Wed, 12 Mar 2025 04:05:16 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: flichtenheld <fr...@lichtenheld.com> Gerrit-MessageType: comment
_______________________________________________ Openvpn-devel mailing list Openvpn-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/openvpn-devel
