Attention is currently required from: d12fk, plaisthos. flichtenheld has posted comments on this change. ( http://gerrit.openvpn.net/c/openvpn/+/838?usp=email )
Change subject: dns: apply settings via script on unixoid systems ...................................................................... Patch Set 10: Code-Review-1 (4 comments) Patchset: PS10: not all of my comments addressed, but works again File distro/dns-scripts/systemd-dns-updown.sh: http://gerrit.openvpn.net/c/openvpn/+/838/comment/b6e04719_5c31cad2 : PS9, Line 75: "$ > Maybe we could add a comment here like: "Add as a routing-only domain (~ > prefix) unless already conf […] Done http://gerrit.openvpn.net/c/openvpn/+/838/comment/00a046e5_14744958 : PS9, Line 75: =~ > This broken now. […] Done http://gerrit.openvpn.net/c/openvpn/+/838/comment/97e01f52_40b91b62 : PS9, Line 116: [ -n "${!transport_var}" -a "${!transport_var}" = "DoH" ] || break > I think this line could use a comment like "skip DoH dns entries", otherwise > it takes a while to und […] Done -- To view, visit http://gerrit.openvpn.net/c/openvpn/+/838?usp=email To unsubscribe, or for help writing mail filters, visit http://gerrit.openvpn.net/settings Gerrit-Project: openvpn Gerrit-Branch: master Gerrit-Change-Id: Ifbe4ffb44d3bfcaa50adb38cacb3436fcdc71b10 Gerrit-Change-Number: 838 Gerrit-PatchSet: 10 Gerrit-Owner: d12fk <he...@openvpn.net> Gerrit-Reviewer: flichtenheld <fr...@lichtenheld.com> Gerrit-Reviewer: plaisthos <arne-open...@rfc2549.org> Gerrit-CC: openvpn-devel <openvpn-devel@lists.sourceforge.net> Gerrit-Attention: plaisthos <arne-open...@rfc2549.org> Gerrit-Attention: d12fk <he...@openvpn.net> Gerrit-Comment-Date: Thu, 06 Mar 2025 12:41:26 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Comment-In-Reply-To: flichtenheld <fr...@lichtenheld.com> Gerrit-MessageType: comment
_______________________________________________ Openvpn-devel mailing list Openvpn-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/openvpn-devel
