Hi Robert, Going to check this.
And yes, I perfectly agree with the deprecation path: 1. Mark as being deprecated int the comments 2. Break user code by moving deprecated stuff in a specific namespace 3. Delete deprecated code definitely Actually it looks a bit like the OpenGL deprecation system (except for the specific namespace), don't you think? -- Sukender ----- Mail original ----- De: "Robert Osfield" <[email protected]> À: "OpenSceneGraph Submissions" <[email protected]> Envoyé: Mardi 25 Juin 2013 18:19:36 Objet: Re: [osg-submissions] Fixed a #include inside a "namespace osg" Hi Sukender, Wow, that ended being a bit of mammoth code conversion session... What I ended up doing is moving the old AttributeBinding that includes BIND_PER_PRIMITIVE into deprecated_osg::Geometry. I then removed the BIND_PER_PRIMITIVE from osg::Geometry, this means that when compiling it's more obvious that you are attempting to use deprecated functionality - it simply won't compile anymore without using deprecated_osg::Geometry. I've gone back and forth on this break users build issue but overall now feels it's probably the right thing to do. I have also moved the implementations from the header back into the .cpp, this will allow us to change the backend implementation without forcing a recompile, and also reduces the library/plugin memory footprint a little bit. I now feel pretty comfortable with this deprecated_osg namespace approach, it gives us a migration path that is clearer and potentially is template for other classes. For osg::Geometry itself the setNormalBinding() etc. methods are deprecated but haven't been migrated to deprecated_osg::Geometry yet, and feel that we can do this after OSG-3.2 is out the door, doing it now would break builds for even valid array and binding usage of the osg::Geometry which I feel is pushing things one to far. Could you do an svn update and check that everything builds under Windows. Thanks, Robert. _______________________________________________ osg-submissions mailing list [email protected] http://lists.openscenegraph.org/listinfo.cgi/osg-submissions-openscenegraph.org _______________________________________________ osg-submissions mailing list [email protected] http://lists.openscenegraph.org/listinfo.cgi/osg-submissions-openscenegraph.org
