Compilation 100% on my config! (Commit 6756cf5) Thanks. -- Sukender
----- Mail original ----- De: "Robert Osfield" <[email protected]> À: "OpenSceneGraph Submissions" <[email protected]> Envoyé: Mercredi 26 Juin 2013 10:55:55 Objet: Re: [osg-submissions] Fixed a #include inside a "namespace osg" Hi Sukender, On 26 June 2013 09:46, Sukender <[email protected]> wrote: > About your changes, everything compiles fine under MSVC2008 (commit a4e9807, > 80 minutes ago), with one exception: FBX WriteNodeVisitor.cpp. > > First, it seems there is a typo. Line 52 reads "geom" instead of "geo" : > if (geo->containsDeprecatedData()) geom->fixDeprecatedData(); > should be replaced by > if (geo->containsDeprecatedData()) geo->fixDeprecatedData(); > > And apart from this, calling fixDeprecatedData() is just impossible on a > const object. Maybe you forgot something? Or maybe something went wrong when > merging into my own repo? > Of course, this is absolutely not specific to MSVC... ;) Ooops... Don't have fbx on my system to test against. I've just removed this line completely as you say it's a const object. This line was just a fallback in case someone was trying to export a deprecated_osg::Geometry object without the fixDeprecatedData() already having been called on it. This might be a bit over protective. Robert. _______________________________________________ osg-submissions mailing list [email protected] http://lists.openscenegraph.org/listinfo.cgi/osg-submissions-openscenegraph.org _______________________________________________ osg-submissions mailing list [email protected] http://lists.openscenegraph.org/listinfo.cgi/osg-submissions-openscenegraph.org
