Hi Robert, I updated the code using a Geometry subclass. It seems okay now. But I have a huge doubt about IVE and "Deprecated OSG" formats: isn't it a problem changing the inheritance there (ive/Geometry.h, deprecated-dotosg/osg/Geometry.cpp)? Could you check this, please?
Based on: commit 8d69f3816ac64013c337f3b86aa04a1f3fbf34b1 Date: Mon Jun 24 12:51:02 2013 +0000 Cheers, -- Sukender ----- Mail original ----- De: "Sukender" <[email protected]> À: "OpenSceneGraph Submissions" <[email protected]> Envoyé: Lundi 24 Juin 2013 17:17:42 Objet: Re: [osg-submissions] Fixed a #include inside a "namespace osg" Mmmmmh... I'll try with a namespace and search/replace. If this works as intended, then I'll submit to you. Stay tuned!!! Cheers, -- Sukender ----- Mail original ----- De: "michael kapelko" <[email protected]> À: "OpenSceneGraph Submissions" <[email protected]> Envoyé: Lundi 24 Juin 2013 16:57:23 Objet: Re: [osg-submissions] Fixed a #include inside a "namespace osg" Namespace sounds interesting. 2013/6/24 Robert Osfield < [email protected] > Hi Sukender, On 24 June 2013 14:29, Sukender < [email protected] > wrote: > Yeah, sure I agree with your reaction... This is nonsense (as long as the > hypothesis is verified). > About the subclass, it could be a nice idea as long as "forced downcast" (ie. > casting a "true" Geometry to a GeometryDeprecated) is possible. Ex: > > p = new Geometry; > > //... somewhere else: > static_cast<GeometryDeprecated*>(p)->someDeprecatedFunction() I think mostly one would just do GeometryDeprecated* gd = new GeometryDeprecated; gs->someDeprecatedFunction(); So just do a search and replace of Geometry with GeometryDeprecated; Another possibility would be to have a deprecated_osg namespace such as namespace deprecated_osg { class Geometry : public osg::Geometry { deprecated methods... }; } Although I'm not sure that is allround a great idea... then none of the solutions are... > May I proceed? With? Robert. _______________________________________________ osg-submissions mailing list [email protected] http://lists.openscenegraph.org/listinfo.cgi/osg-submissions-openscenegraph.org _______________________________________________ osg-submissions mailing list [email protected] http://lists.openscenegraph.org/listinfo.cgi/osg-submissions-openscenegraph.org _______________________________________________ osg-submissions mailing list [email protected] http://lists.openscenegraph.org/listinfo.cgi/osg-submissions-openscenegraph.org
2013-06-25 osg_deprecated Geometry.7z
Description: application/7z-compressed
_______________________________________________ osg-submissions mailing list [email protected] http://lists.openscenegraph.org/listinfo.cgi/osg-submissions-openscenegraph.org
