Hi Robert,
Yes, conceptually...
About your changes, everything compiles fine under MSVC2008 (commit a4e9807, 80
minutes ago), with one exception: FBX WriteNodeVisitor.cpp.
First, it seems there is a typo. Line 52 reads "geom" instead of "geo" :
if (geo->containsDeprecatedData()) geom->fixDeprecatedData();
should be replaced by
if (geo->containsDeprecatedData()) geo->fixDeprecatedData();
And apart from this, calling fixDeprecatedData() is just impossible on a const
object. Maybe you forgot something? Or maybe something went wrong when merging
into my own repo?
Of course, this is absolutely not specific to MSVC... ;)
--
Sukender
----- Mail original -----
De: "Robert Osfield" <[email protected]>
À: "OpenSceneGraph Submissions" <[email protected]>
Envoyé: Mercredi 26 Juin 2013 09:28:26
Objet: Re: [osg-submissions] Fixed a #include inside a "namespace osg"
On 26 June 2013 06:48, Sukender <[email protected]> wrote:
> And yes, I perfectly agree with the deprecation path:
> 1. Mark as being deprecated int the comments
> 2. Break user code by moving deprecated stuff in a specific namespace
> 3. Delete deprecated code definitely
You've summed it up pretty well. It's not been a direct route to get
here but it does feel like the solution the current solution is easy
to understand and convey.
> Actually it looks a bit like the OpenGL deprecation system (except for the
> specific namespace), don't you think?
Conceptually perhaps...
_______________________________________________
osg-submissions mailing list
[email protected]
http://lists.openscenegraph.org/listinfo.cgi/osg-submissions-openscenegraph.org
_______________________________________________
osg-submissions mailing list
[email protected]
http://lists.openscenegraph.org/listinfo.cgi/osg-submissions-openscenegraph.org
