Hi Pjotr, On 15 May 2014 09:08, Pjotr Svetachov <[email protected]> wrote: > I have compiled osg successfully with and without osg_use_bound and > everything seems to work with our software. (For the record, I only had to > change two lines of code to make our software compile without osg_use_bound)
Thanks for diving in with testing this bleeding edge code. What changes did you have to make? How big is your codebase? I'd like to get a feel for what type of changes users have had to make. > Another solution would be to have two geometry nodes side by side, one to be > used with geodes and one that can be attached to nodes directly. Then have > the Geodes and the old Geometry node deprecated so people have time to update > the code base. You could for instance in the next osg version deprecate it > with maybe a compile time warning, then in the osg version after that also > add runtime a warning when these types of nodes constructed and in the > version after that just remove them. But this of course will mean we will > have a lot of duplicate code for the next few osg versions. More classes is the exactly opposite from where I'm trying to go with these changes :-) > By the way, adding drawables to nodes would also degrade performance a bit as > drawables attached to nodes will have a boundingbox with a sphere around it > making all the parent bounding spheres larger that previously. This won't > impact draw performance as at the end osg culls using the bounding boxes but > it could impact cull traversal time as it will travel deeper into the tree > before it starts to cull out nodes. I hadn't thought of this enlarged bounding volume issue with adding Drawable directly to Group. The solution would be to check whether a child is a Drawable and has a bounding box and then handle this in the Group::computeBound(). I have look at implementing this now. Robert. _______________________________________________ osg-users mailing list [email protected] http://lists.openscenegraph.org/listinfo.cgi/osg-users-openscenegraph.org
