Jan, Uwe: The values were switched as a result of the change I submitted to Paul a couple of years ago. I was experimenting with the MAX31850 and getting what I thought were garbage results. I was not familiar with the code and submitted a simple change that I worked out empirically by inspecting the data structure for the device. I was unaware of the man page for this device and assumed the thermocouple temperature (hot junction) should be returned by a "temperature" query.
For my changes I assumed the OWFS implementation should follow a consistent object model where the measured temperature is returned with a standard query (one of the "temperature" values), and explained to Paul what I had done. I assume he was too busy at the time to pay much attention to what I was saying and he committed my changes without review. I see Jan just applied the patch to bring the code back in line with the documentation. I don't think many people are using this, and if they are they're not paying attention to the documentation, so I doubt there will be much response to the change. While use is still limited I'd encourage you to consider following the object model for other temperature devices, and change the documentation to concur. I'm sure this would still require some code cleanup. I'm not invested in this approach in any way, I just think it's a cleaner implementation from a device abstraction perspective. Regards, Paul Panish Uwe Bonnes wrote: >>>>>> "Jan" == Jan Kandziora<j...@gmx.de> writes: > > Jan> Am 09.09.2016 um 11:15 schrieb Uwe Bonnes: > Jan> Uwe, I am not sure how we should handle this. IIRC, in the past, > Jan> the temperature values had been the way you suggest. But for some > Jan> reason I not aware anymore, this had been switched. > > My patch handles it at it is describes in ./src/man/man3/DS1825.man for the > MAX31850. > > Jan> We have to find the reason why it's bogus as it is now. > > The reason why it is bogus is, that the present code does not return values > according to the secription in the man page. > > If it has switched, the man-page should be updated... > > Bye ------------------------------------------------------------------------------ _______________________________________________ Owfs-developers mailing list Owfs-developers@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/owfs-developers
