>>>>> "Paul" == Paul W Panish <ppan...@panishnet.com> writes:
Paul> Jan, Uwe: The values were switched as a result of the change I
Paul> submitted to Paul a couple of years ago. I was experimenting with
Paul> the MAX31850 and getting what I thought were garbage results. I
Paul> was not familiar with the code and submitted a simple change that
Paul> I worked out empirically by inspecting the data structure for the
Paul> device. I was unaware of the man page for this device and assumed
Paul> the thermocouple temperature (hot junction) should be returned by
Paul> a "temperature" query.
Paul> For my changes I assumed the OWFS implementation should follow a
Paul> consistent object model where the measured temperature is returned
Paul> with a standard query (one of the "temperature" values), and
Paul> explained to Paul what I had done. I assume he was too busy at the
Paul> time to pay much attention to what I was saying and he committed
Paul> my changes without review.
Paul> I see Jan just applied the patch to bring the code back in line
Paul> with the documentation. I don't think many people are using this,
Paul> and if they are they're not paying attention to the documentation,
Paul> so I doubt there will be much response to the change.
Paul> While use is still limited I'd encourage you to consider following
Paul> the object model for other temperature devices, and change the
Paul> documentation to concur. I'm sure this would still require some
Paul> code cleanup. I'm not invested in this approach in any way, I just
Paul> think it's a cleaner implementation from a device abstraction
Paul> perspective.
So you mean that */temperature* should return the thermocouple temperature
and */thermocouple should vanish and */coldjunction (or a similar name)
should appear and return the internal temperature?
This sounds also much clearer to me and I will try to make a patch to the
docs and the code, if I get confirmation that this approch is right.
Any other ideas for a sensible filename to return internal temperature?
Bye
--
Uwe Bonnes b...@elektron.ikp.physik.tu-darmstadt.de
Institut fuer Kernphysik Schlossgartenstrasse 9 64289 Darmstadt
--------- Tel. 06151 1623569 ------- Fax. 06151 1623305 ---------
------------------------------------------------------------------------------
_______________________________________________
Owfs-developers mailing list
Owfs-developers@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/owfs-developers
