Zdenek Kotala wrote:
> Alvaro Herrera wrote:

>>> 1) I removed sugar word from postgres.h and put them closer to consumer 
>>> :-). I created include/catalog/genbki.h which contains sugar words - 
>>> macros for correct catalog data processing. All catalogs file now include 
>>> this header.
>> What's the point of this?  I don't see what difference it makes from the
>> current situation.  In particular I don't see it being included in any
>> new place.

> pg_dump.c needs some macros which are defined into catalogs header. But it 
> should not include postgres.h where is defined "sugar words" for catalog 
> data. It is the reason why I moved these macros to the separate header and 
> include this header from all catalog header.

Ah, the part that I was missing was that the catalog headers were being
included by pg_dump.c.

Alvaro Herrera                                http://www.CommandPrompt.com/
PostgreSQL Replication, Consulting, Custom Development, 24x7 support

---------------------------(end of broadcast)---------------------------
TIP 3: Have you checked our extensive FAQ?


Reply via email to