[EMAIL PROTECTED] wrote:
> I took a look at the bug for 3726 and the webrev.  I don't understand
> your comment:
> 
>       This is also why the traceback for the touch_manifest error
>       didn't show up until after Danek's fix for bug 3714 which was a
>       fix for a bug in changeset 556's get_version_installed addition
>       which was really caused by a bug (imo) in
>       image.installed_file_authority().
> 
> What does installed_file_authority() have to do with exception handling?

installed_file_authority() is what get_version_installed() relied on. 
Since it retained the old authority even though that authority had been 
removed, get_version_installed() would return nothing which in turn 
would cause has_version_installed() to return false which in turn would 
cause propose_fmri_removal() to return without doing anything.

This resulted in an assertion failure of ip.nothingtodo() because 
propose_fmri_removal() hadn't proposed anything for removal.

Cheers,
-- 
Shawn Walker
_______________________________________________
pkg-discuss mailing list
[email protected]
http://mail.opensolaris.org/mailman/listinfo/pkg-discuss

Reply via email to