On Tue 07 Oct 2008 at 03:34PM, Shawn Walker wrote:
> Greetings,
>
> The following webrev contains fixes for the following issues:
> 3726 pkg uninstall fails if old manifest cannot be retrieved
>
> webrev:
> http://cr.opensolaris.org/~swalker/pkg-3726/
>
> Change Summary
> ==============
> * Changed retrieve.touch_manifest() to only raise KeyboardInterrupt or
> ManifestRetrievalError since this is a HEAD operation that isn't critical.
>
> * Fixed a few other exception handler in retrieve.py to also allow
> KeyboardInterrupt to be raised.
>
> * Changed image.py's exception handling for touch_manifest to only look
> for ManifestRetrievalError.
I don't understand this review too well.
retrieve.py: I don't see how these 'except KeyboardInterrupt' statements
do anything new we weren't doing before. What am I missing? The
default thing which will happen is the kbd interrupt exception will be
raised, so adding a statement here would seem to have no effect.
In touch_manifest, I don't understand why you raise ManifestRetrievalError
only to have the caller ignore it. Why raise it at all? Seems like the
caller should be able to be written as:
retrieve.touch_manifest(self, fmri)
with no try/except.
-dp
--
Daniel Price - Solaris Kernel Engineering - [EMAIL PROTECTED] - blogs.sun.com/dp
_______________________________________________
pkg-discuss mailing list
[email protected]
http://mail.opensolaris.org/mailman/listinfo/pkg-discuss
