Dan Price wrote: > On Tue 07 Oct 2008 at 03:34PM, Shawn Walker wrote: >> Greetings, >> >> The following webrev contains fixes for the following issues: >> 3726 pkg uninstall fails if old manifest cannot be retrieved >> >> webrev: >> http://cr.opensolaris.org/~swalker/pkg-3726/ ... > In touch_manifest, I don't understand why you raise ManifestRetrievalError > only to have the caller ignore it. Why raise it at all? Seems like the > caller should be able to be written as: > > retrieve.touch_manifest(self, fmri) > > with no try/except.
Because I wanted the caller to choose whether or not it was considered an error instead of coding that behaviour into the retrieve function itself. -- Shawn Walker _______________________________________________ pkg-discuss mailing list [email protected] http://mail.opensolaris.org/mailman/listinfo/pkg-discuss
