On Tue 07 Oct 2008 at 07:27PM, Shawn Walker wrote:
> 
> Because I wanted the caller to choose whether or not it was considered 
> an error instead of coding that behaviour into the retrieve function itself.

Is there any other caller other than this?  Otherwise this seems
like coding for some future which might never happen.  It just seems
like a pitfall to me-- less error paths are usually better than more.

At least put a comment.  Now that I look again, the error handling in
image.py also doesn't jibe with the comment below, it, which says:

 "Manifests should only be marked as processed if the
 touch is actually performed since multiple retrievals
 may occur during the same operation for different reasons."

        -dp

-- 
Daniel Price - Solaris Kernel Engineering - [EMAIL PROTECTED] - blogs.sun.com/dp
_______________________________________________
pkg-discuss mailing list
[email protected]
http://mail.opensolaris.org/mailman/listinfo/pkg-discuss

Reply via email to