Danek Duvall wrote: > On Tue, Oct 07, 2008 at 03:34:26PM -0500, Shawn Walker wrote: > >> http://cr.opensolaris.org/~swalker/pkg-3726/ > > retrieve.py: > > - line 125, 145: why are these here? There's nothing that would catch > and suppress KeyboardInterrupt here, so there's no need to be explicit > here in catching it and re-raising it.
Because I had mistakenly thought they were except Exception cases or "except:". Removed. > Otherwise, it looks fine to me, but I guess I don't understand where the > NameError in my stack trace was coming from, since we're not raising a > NameError anywhere in there, and I'm not sure how changeset 563 would have > revealed one. I'm probably just confused here. Changeset 562 changed get_manifest to use ManifestRetrievalError and DatastreamRetrievalError but didn't change touch_manifest to use it which left it with a non-existent exception of NameError. While merging those changes for my commit, 563, I also failed to notice that NameError should be changed to ManifestRetrievalError. Changeset 565 added back all of the exception code I had previously removed and had touch_manifest setup to raise several different errors which was problematic since the code calling touch_manifest() was only expecting ManifestRetrievalError or DatastreamRetrievalError. That is why you saw NameError in your traceback. Cheers, -- Shawn Walker _______________________________________________ pkg-discuss mailing list [email protected] http://mail.opensolaris.org/mailman/listinfo/pkg-discuss
