Shawn Walker wrote:
Shawn Walker wrote:
Greetings,

The following webrev contains fixes for the following issues:

  7900 set-publisher and unset-publisher need to show progress
  8214 load_catalogs should only load catalog data when needed
8326 fancy progress tracker output wrong if cache load fails during catalog refresh
  8327 catalog cache load and generation progress tracking desired

webrev:
http://cr.opensolaris.org/~swalker/pkg-8214/

I need one more reviewer for these changes.

Thanks!

image.py:
unless there's an immediate practical reason to make these variables and methods private, or you're really, really sure that you got every place they're used, I'd make those changes after this release.


724-736:
duplicated code?

Other than that, LGTM I think.

Brock
_______________________________________________
pkg-discuss mailing list
[email protected]
http://mail.opensolaris.org/mailman/listinfo/pkg-discuss

Reply via email to