[email protected] wrote:
On Tue, Apr 21, 2009 at 10:39:41PM -0500, Shawn Walker wrote:
webrev:
http://cr.opensolaris.org/~swalker/pkg-8214/
gui/modules/misc.py:
- line 41: Obviously not your fault, but shouldn't this actually be
asking the API itself, instead of hard coding the value into an
obscure location?
No, the value here represents what version of the API the GUI speaks,
not what the current version of the API is.
api.py:
- line 91: In versions.txt, it looks like you skipped straight from
12 to 14. I'm probably missing something, but why the two version
jump?
I didn't, look at line 12 of client_api_versions.txt. What happened was
that when I added version 12, I bumped the version to 13 in
client_api_versions.txt because of a merge that already had version 12,
but forgot to increment it in pkg.client.api.
image.py:
- Could you extract the catalog cache methods from image into their
own CatalogCache object? I'd like to avoid having the image accrete
random procedrual methods.
These methods were already present (its hard to see that from the diff).
Since I merely fixed some behaviours, I think that's a different wad.
Cheers,
--
Shawn Walker
_______________________________________________
pkg-discuss mailing list
[email protected]
http://mail.opensolaris.org/mailman/listinfo/pkg-discuss
