Shawn Walker wrote:
Brock Pytlik wrote:
Shawn Walker wrote:
Shawn Walker wrote:
webrev:
http://cr.opensolaris.org/~swalker/pkg-8214/
I need one more reviewer for these changes.
Thanks!
image.py:
unless there's an immediate practical reason to make these variables
and methods private, or you're really, really sure that you got every
place they're used, I'd make those changes after this release.
Nothing should have ever been using these outside of image or our
gate, and I've done a very thorough search for them. I'll done one
last check to be certain.
724-736:
duplicated code?
No, there's a subtle difference here. When an actual Exception object
gets raised for an exception, log_operation_end is called with error=e.
When a generic exception is raised (with a string or somesuch thing),
then log_operation_end() is called with result=RESULT_FAILED_UNKNOWN.
Comment that please then.
Brock
Cheers,
_______________________________________________
pkg-discuss mailing list
[email protected]
http://mail.opensolaris.org/mailman/listinfo/pkg-discuss
