[email protected] wrote:
On Wed, Apr 22, 2009 at 12:54:20PM -0500, Shawn Walker wrote:
[email protected] wrote:
On Tue, Apr 21, 2009 at 10:39:41PM -0500, Shawn Walker wrote:
webrev:
http://cr.opensolaris.org/~swalker/pkg-8214/
gui/modules/misc.py:
- line 41: Obviously not your fault, but shouldn't this actually be
asking the API itself, instead of hard coding the value into an
obscure location?
No, the value here represents what version of the API the GUI speaks,
not what the current version of the API is.
Alright. Could I put upon you to add a comment to this routine. I know
you didn't write it, but it would prevent others from making the same
mistake that I did.
Well - I thought the comment was meant to do that:
def get_client_api_version():
41 - return 12 # CLIENT_API_VERSION Used by PM, UM and WebInstall
But happy for Shawn to add something more explicit:
def get_client_api_version():
"""Return the current version of the Client API the PM, UM and
WebInstall GUIs have
been tested against and are known to work with."""
return 14 # CLIENT_API_VERSION Used by PM, UM and WebInstall
JR
_______________________________________________
pkg-discuss mailing list
[email protected]
http://mail.opensolaris.org/mailman/listinfo/pkg-discuss
