On Tue, Apr 21, 2009 at 10:39:41PM -0500, Shawn Walker wrote:
> webrev:
> http://cr.opensolaris.org/~swalker/pkg-8214/
gui/modules/misc.py:
- line 41: Obviously not your fault, but shouldn't this actually be
asking the API itself, instead of hard coding the value into an
obscure location?
api.py:
- line 91: In versions.txt, it looks like you skipped straight from
12 to 14. I'm probably missing something, but why the two version
jump?
image.py:
- Could you extract the catalog cache methods from image into their
own CatalogCache object? I'd like to avoid having the image accrete
random procedrual methods.
- line 2060: Would you please add a docstring for this method?
publisher.py:
- line 920, 933: Why if and not elif here?
Otherwise this looks good.
Thanks for fixing this.
-j
_______________________________________________
pkg-discuss mailing list
[email protected]
http://mail.opensolaris.org/mailman/listinfo/pkg-discuss
