Danek Duvall wrote:
On Wed, Apr 22, 2009 at 12:09:28PM -0500, Shawn Walker wrote:
That would make it largely inconsistent with the existing ProgressTracker
implementation (and completely in the case of catalog process). I'm not
the one that designed the ProgressTracker class, so I don't feel qualified
to make that decision.
"Largely" refers to the three methods which currently *don't* raise
NotImplementedError? Those should probably be fixed.
Correct, and I agree with you given the comment in ProgressTracker's
docstring:
Subclasses must implement all of the *_output_* methods.
Anyone who wants to be insulated from new methods being added should
inherit from NullProgressTracker, rather than ProgressTracker. I don't
know that that was the intent, but it's safe, and will do the right thing
in this instance -- ignore methods you haven't implemented yet or don't
care about.
I have to agree. I think we should add this suggestion to the docstring
for NullProgressTracker and ProgressTracker.
I'll open a bug to make both of the above changes.
Cheers,
--
Shawn Walker
_______________________________________________
pkg-discuss mailing list
[email protected]
http://mail.opensolaris.org/mailman/listinfo/pkg-discuss
