On 10/ 4/10 03:34 PM, Bart Smaalders wrote:
Pretty simple:
http://cr.opensolaris.org/~barts/12530/
12530 pkg -R install doesn't update boot archive
Mostly nits.
modules/client/api.py:
line 3033: extra newline here; thanks
modules/client/bootenv.py:
line 73: can you add the comment we talked about here that indicates
why the root at the time of init is important? (i.e. we
know where the source BE for the clone is because of root.)
line 316: s/[ "/["/
line 320: file("/dev/null") should really be: open(os.devnull)
line 330: the return's sort of pointless, right? and just to verify,
I assume it's intentional that we just log any problems
encountered here and drive on? An explicit statement of
intent would be good then.
modules/client/imageplan.py:
line 1010: s/is False/= False/ ?
Cheers,
-Shawn
_______________________________________________
pkg-discuss mailing list
[email protected]
http://mail.opensolaris.org/mailman/listinfo/pkg-discuss
