On 01/ 6/11 09:03 AM, Bart Smaalders wrote:
Pretty simple; addition of optional argument
to API caused a lot of files to be touched
trivially.
http://cr.opensolaris.org/~barts/17581/
doc/client_api_versions.txt:
needs update
src/client.py:
line 160: missing --reject
line 168: s/exclude/reject/
line 169: missing indent
src/gui/modules/misc_non_gui.py:
copyright 2011
src/man/pkg.1.txt:
lines 238-240: suggest:
With --reject, prevent packages matching the given pattern from
being installed. If matching packages are already installed, they
will be removed as part of the operation.
general: we might also want an example of how/why you would use reject
for an obsolete package case or an IDR possibly -- you could just file
a bug for now on that until we have a final scheme for IDR packages
line 257: missing --reject here only; you don't need
the description of the option below
src/modules/client/api.py:
line 142: need to add 48 to compatible_versions since your change is
a compatible one that only adds an additional parameter to existing
functions
lines 418, 536, 615: s/()/misc.EmptyI/
line 439: suggest: 'reject_pats' or 'reject_pkgs' instead of
'disallow_list'
line 625: don't need this given lines 627-628.
src/modules/client/api_errors.py:
looks like you can revert this file; no real changes
src/modules/client/image.py:
copyright 2011
src/modules/client/imageplan.py:
line 1: shebang line change???
line 24: copyright 2011
src/modules/client/pkg_solver.py:
line 172: s/required to be/allowed to be in the/ ?
line 234: I wouldn't say command line because of GUI clients, etc.
Suggest: "This version rejected per user request" or something like
that.
line 1369: stray whitespace
src/tests/cli/t_pkg_install.py:
line 677: s/without/reject/
line 832: insert newline
general: maybe add test case for rejecting specific pub's packages?
-Shawn
_______________________________________________
pkg-discuss mailing list
[email protected]
http://mail.opensolaris.org/mailman/listinfo/pkg-discuss
