On 01/24/11 18:40, Shawn Walker wrote:
line 1061: nit: should 270, 281, 1647 have single quotes around {0}
too?
Actually, I use the ' ' marks when there is the possibility of
confusing field in question. FMRIs are pretty distinctive, and
don't need setting off like dependency type names or pkg stems
do.
line 1632: So, completely optional, but if you changed __trim_dict
into a collections.defaultdict, you could dump the function call,
and this would be slightly faster. So:
Cool - I'm trying this in a couple of places.
Last comment is whether these changes now show the user the rollup of
their install holds as part of the plan output? For example, something
like this:
# pkg update -n
Updating:
[email protected] -> [email protected]
...or if entire is not installed:
# pkg update-n
Updating:
consolidation/nvidia/[email protected] ->
consolidation/nvidia/[email protected]
consolidation/osnet/[email protected] ->
consolidation/osnet/[email protected]
I'll file an RFE on this.
Other comments accepted as written.
- Bart
--
Bart Smaalders Solaris Kernel Performance
[email protected] http://blogs.sun.com/barts
"You will contribute more with Mercurial than with Thunderbird."
"Civilization advances by extending the number of important
operations which we can perform without thinking about them."
_______________________________________________
pkg-discuss mailing list
[email protected]
http://mail.opensolaris.org/mailman/listinfo/pkg-discuss
