On 01/26/11 04:12 PM, Bart Smaalders wrote:
http://cr.opensolaris.org/~barts/16279/
16279 Need a way to revert certain editable files to a as-installed state
17775 introduction of system/volatile breaks device action tests
src/client.py:
line 1659: int: missing '.'
src/man/pkg.1.txt:
lines 34, 207, 208, 209: trailing whitespace
line 295: s/. File/. File/
line 295: s/individual files may be reverted/individual files/ ?
line 297: s/. Caution/. Caution/
s/system/the system/ ?
line 302: extra newline
src/man/pkg.5.txt:
update needed for revert tags
also should those be 'pkg.revert-tag' instead?
doc/client/api_versions.txt:
needs a brief blurb about the new function in ImageInterface,
pkg.client.api_errors, etc. (anything in pkg.client)
src/modules/client/api.py:
line 68: need to bump API version to 50
line 146: need to add 49 to compatible_versions
line 720: why VARCET as the default?
line 745: docstring needs to document 'tagged' and 'relpaths'
parameter; for the remaining ones it can simply say:
For all other parameters, refer to the 'plan_install' function
for an explanation of their usage and effects.
src/modules/client/api_errors.py:
line 435: s/are not/could not be/
src/modules/client/imageplan.py:
line 373: relpaths is unused? i'll ask you about this
line 374: trailing whitespace
line 388: redundant to say "; it doesn't matter." ?
line 408: s/[ peel/[peel/
line 422: why self.image.list_excludes instead of self.__new_excludes?
line 432-433: can simplify to: act.attrs.pop("preserve", None)
line 451: stray newline?
src/tests/cli/t_fix.py:
line 23: copyright
src/tests/cli/t_pkg_revert.py:
line 24: s/2008, '//
lines 33, 34, 37, 38, 39, 40: unused import
lines 128, 136: nit: s/C,D/C, D/
lines 163-164: missing standard test block:
if __name__ == "__main__":
unittest.main()
* What happens if publisher of package containing file is
disabled? (failure mode?)
* What happens if publisher of package containing file doesn't
have package data? (failure mode?; need to set-property
flush-content-cache-on-success True after image create)
-Shawn
_______________________________________________
pkg-discuss mailing list
[email protected]
http://mail.opensolaris.org/mailman/listinfo/pkg-discuss
