Mmuzaf commented on code in PR #2046:
URL: https://github.com/apache/cassandra/pull/2046#discussion_r1058448721
##########
src/java/org/apache/cassandra/utils/JMXServerUtils.java:
##########
@@ -224,15 +229,15 @@ private static Map<String, Object>
configureJmxSocketFactories(InetAddress serve
String protocolList =
COM_SUN_MANAGEMENT_JMXREMOTE_SSL_ENABLED_PROTOCOLS.getString();
if (protocolList != null)
{
- System.setProperty("javax.rmi.ssl.client.enabledProtocols",
protocolList);
+ JAVAX_RMI_SSL_CLIENT_ENABLEDPROTOCOLS.setString(protocolList);
protocols = StringUtils.split(protocolList, ',');
}
String[] ciphers = null;
String cipherList =
COM_SUN_MANAGEMENT_JMXREMOTE_SSL_ENABLED_CIPHER_SUITES.getString();
if (cipherList != null)
{
- System.setProperty("javax.rmi.ssl.client.enabledCipherSuites",
cipherList);
+ JAVAX_RMI_SSL_CLIENT_ENABLEDCIPHERSUITES.setString(cipherList);
Review Comment:
Fixed.
##########
src/java/org/apache/cassandra/utils/MonotonicClock.java:
##########
@@ -139,8 +140,7 @@ private static MonotonicClock approx(MonotonicClock precise)
static abstract class AbstractEpochSamplingClock implements MonotonicClock
{
private static final Logger logger =
LoggerFactory.getLogger(AbstractEpochSamplingClock.class);
- private static final String UPDATE_INTERVAL_PROPERTY =
Config.PROPERTY_PREFIX + "NANOTIMETOMILLIS_TIMESTAMP_UPDATE_INTERVAL";
- private static final long UPDATE_INTERVAL_MS =
Long.getLong(UPDATE_INTERVAL_PROPERTY, 10000);
+ private static final long UPDATE_INTERVAL_MS =
NANOTIMETOMILLIS_TIMESTAMP_UPDATE_INTERVAL.getLong();
Review Comment:
Fixed.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
