Mmuzaf commented on code in PR #2046:
URL: https://github.com/apache/cassandra/pull/2046#discussion_r1059007078
##########
src/java/org/apache/cassandra/gms/FailureDetector.java:
##########
@@ -476,16 +470,12 @@ public long[] getArrivalIntervals()
private static long getMaxInterval()
{
- String newvalue = System.getProperty("cassandra.fd_max_interval_ms");
Review Comment:
I updated this part according to your suggestions in general.
The main thing here is that the `getMaxInterval` method uses the
`INITIAL_VALUE_NANOS` constant as a default value. Which in turn is initialized
by the `getInitialValue` method call and can't be changed in runtime further,
thus changing the `cassandra.fd_initial_value_ms` will have no effect until
restart.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
