Mmuzaf commented on code in PR #2046:
URL: https://github.com/apache/cassandra/pull/2046#discussion_r1058515224
##########
test/distributed/org/apache/cassandra/distributed/test/AlterTest.java:
##########
@@ -98,7 +99,7 @@ public void
alteringKeyspaceOnInsufficientNumberOfReplicasFiltersOutGossppingOnl
{
IInstanceConfig config = cluster.newInstanceConfig();
IInvokableInstance gossippingOnlyMember =
cluster.bootstrap(config);
- withProperty("cassandra.join_ring", Boolean.toString(false), () ->
gossippingOnlyMember.startup(cluster));
+ withProperty(CassandraRelevantProperties.JOIN_RING, false, () ->
gossippingOnlyMember.startup(cluster));
Review Comment:
Fixed here and for all other similar cases.
##########
test/distributed/org/apache/cassandra/distributed/test/IPMembershipTest.java:
##########
@@ -64,7 +65,7 @@ public void sameIPFailWithoutReplace() throws IOException
nodeToReplace.config().set("auto_bootstrap", auto_bootstrap);
Assertions.assertThatThrownBy(() -> nodeToReplace.startup())
- .hasMessage("A node with address /127.0.0.3:7012
already exists, cancelling join. Use cassandra.replace_address if you want to
replace this node.");
+ .hasMessage("A node with address /127.0.0.3:7012
already exists, cancelling join. Use " + REPLACE_ADDRESS.getKey() + " if you
want to replace this node.");
Review Comment:
Fixed.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
