Mmuzaf commented on code in PR #2046:
URL: https://github.com/apache/cassandra/pull/2046#discussion_r1058550876
##########
test/unit/org/apache/cassandra/config/CassandraRelevantPropertiesTest.java:
##########
@@ -32,12 +32,12 @@ public void testString()
{
try
{
- System.setProperty(TEST_PROP.getKey(), "some-string");
Review Comment:
Agree, let's add a new test here to be sure that we properties are set under
the hood.
##########
test/unit/org/apache/cassandra/SchemaLoader.java:
##########
@@ -757,7 +760,7 @@ public static void cleanupSavedCaches()
private static CompressionParams compressionParams(int chunkLength)
{
- String algo = System.getProperty("cassandra.test.compression.algo",
"lz4").toLowerCase();
+ String algo = TEST_COMPRESSION_ALGO.getString("lz4").toLowerCase();
Review Comment:
Done.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
