smiklosovic commented on code in PR #2046:
URL: https://github.com/apache/cassandra/pull/2046#discussion_r1153051623
##########
src/java/org/apache/cassandra/service/reads/repair/BlockingReadRepairs.java:
##########
@@ -33,14 +33,14 @@
import org.apache.cassandra.schema.TableMetadata;
import org.apache.cassandra.tracing.Tracing;
+import static
org.apache.cassandra.config.CassandraRelevantProperties.DROP_OVERSIZED_READ_REPAIR_MUTATIONS;
import static org.apache.cassandra.db.IMutation.MAX_MUTATION_SIZE;
public class BlockingReadRepairs
{
private static final Logger logger =
LoggerFactory.getLogger(BlockingReadRepairs.class);
- private static final boolean DROP_OVERSIZED_READ_REPAIR_MUTATIONS =
- Boolean.getBoolean("cassandra.drop_oversized_readrepair_mutations");
+ private static final boolean DROP_OVERSIZED_READ_REPAIR_MUTATIONS_PROP =
DROP_OVERSIZED_READ_REPAIR_MUTATIONS.getBoolean();
Review Comment:
should not this be named `DROP_OVERSIZED_READ_REPAIR_MUTATIONS_VALUE` ?
PROP -> VALUE. That thing is not "property". It is its value.
Even better, it might be called:
`SHOULD_DROP_OVERSIZED_READ_REPAIR_MUTATIONS`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
