smiklosovic commented on code in PR #2046:
URL: https://github.com/apache/cassandra/pull/2046#discussion_r1153063609
##########
src/java/org/apache/cassandra/utils/FBUtilities.java:
##########
@@ -458,15 +463,15 @@ public static String getReleaseVersionString()
{
Properties props = getVersionProperties();
if (props == null)
- return System.getProperty("cassandra.releaseVersion",
UNKNOWN_RELEASE_VERSION);
+ return RELEASE_VERSION.getString();
Review Comment:
I would not put "Unknown" as default in CassandraRelevantProperties but I
would do `RELEASE_VERSION.getString(UNKNOWN_RELEASE_VERSION)`. As it is done
now, we have "Unknown" at two places - in `CassandraRelevantProperties` as
default and the second time as a value in `UNKNOWN_RELEASE_VERSION` constant.
Having it once is enough.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
