smiklosovic commented on code in PR #2046:
URL: https://github.com/apache/cassandra/pull/2046#discussion_r1153064633
##########
src/java/org/apache/cassandra/utils/FBUtilities.java:
##########
@@ -458,15 +463,15 @@ public static String getReleaseVersionString()
{
Properties props = getVersionProperties();
if (props == null)
- return System.getProperty("cassandra.releaseVersion",
UNKNOWN_RELEASE_VERSION);
+ return RELEASE_VERSION.getString();
return props.getProperty("CassandraVersion");
}
public static String getGitSHA()
{
Properties props = getVersionProperties();
if (props == null)
- return System.getProperty("cassandra.gitSHA", UNKNOWN_GIT_SHA);
Review Comment:
same comment as above
##########
src/java/org/apache/cassandra/tools/Util.java:
##########
@@ -49,11 +49,12 @@
import org.apache.cassandra.utils.streamhist.TombstoneHistogram;
import static java.lang.String.format;
+import static
org.apache.cassandra.config.CassandraRelevantProperties.TEST_UTIL_ALLOW_TOOL_REINIT_FOR_TEST;
@SuppressWarnings("serial")
public final class Util
{
- public static final String ALLOW_TOOL_REINIT_FOR_TEST =
Util.class.getName() + "ALLOW_TOOL_REINIT_FOR_TEST"; // Necessary for testing
+ public static final String ALLOW_TOOL_REINIT_FOR_TEST =
TEST_UTIL_ALLOW_TOOL_REINIT_FOR_TEST.getKey(); // Necessary for testing
Review Comment:
this became unused.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
