smiklosovic commented on code in PR #2046:
URL: https://github.com/apache/cassandra/pull/2046#discussion_r1153060097
##########
src/java/org/apache/cassandra/utils/DiagnosticSnapshotService.java:
##########
@@ -139,7 +140,7 @@ private void maybeTriggerSnapshot(TableMetadata metadata,
String prefix, Iterabl
long now = nanoTime();
AtomicLong cached = lastSnapshotTimes.computeIfAbsent(metadata.id, u
-> new AtomicLong(0));
long last = cached.get();
- long interval =
Long.getLong("cassandra.diagnostic_snapshot_interval_nanos",
SNAPSHOT_INTERVAL_NANOS);
+ long interval =
DIAGNOSTIC_SNAPSHOT_INTERVAL_NANOS.getLong(SNAPSHOT_INTERVAL_NANOS);
Review Comment:
`SNAPSHOT_INTERVAL_NANOS` seems to be OK to move to
CassandraRelevantProperties as default value as it is done for similar
properties there, since it is private in this class and not used anywhere else
but here.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
