mike-tr-adamson commented on code in PR #2492:
URL: https://github.com/apache/cassandra/pull/2492#discussion_r1269365837
##########
src/java/org/apache/cassandra/index/sai/disk/StorageAttachedIndexWriter.java:
##########
@@ -74,19 +71,17 @@ public static StorageAttachedIndexWriter
createBuilderWriter(IndexDescriptor ind
LifecycleNewTracker lifecycleNewTracker,
boolean
perIndexComponentsOnly) throws IOException
{
- return new StorageAttachedIndexWriter(indexDescriptor, indexes,
lifecycleNewTracker, perIndexComponentsOnly, true);
+ return new StorageAttachedIndexWriter(indexDescriptor, indexes,
lifecycleNewTracker, perIndexComponentsOnly);
}
private StorageAttachedIndexWriter(IndexDescriptor indexDescriptor,
Collection<StorageAttachedIndex>
indexes,
LifecycleNewTracker lifecycleNewTracker,
- boolean perIndexComponentsOnly,
- boolean propagateErrors) throws
IOException
+ boolean perIndexComponentsOnly) throws
IOException
{
this.indexDescriptor = indexDescriptor;
- this.indexes = indexes;
+ //this.indexes = indexes;
Review Comment:
nit: Can remove
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
