mike-tr-adamson commented on code in PR #2492:
URL: https://github.com/apache/cassandra/pull/2492#discussion_r1269370981
##########
src/java/org/apache/cassandra/index/sai/disk/format/OnDiskFormat.java:
##########
@@ -115,22 +115,18 @@ PerColumnIndexWriter
newPerColumnIndexWriter(StorageAttachedIndex index,
*
* @param indexDescriptor The {@link IndexDescriptor} for the SSTable SAI
index
* @param checksum {@code true} if the checksum should be tested as part
of the validation
- *
- * @return true if all the per-SSTable components are valid
*/
- boolean validatePerSSTableIndexComponents(IndexDescriptor indexDescriptor,
boolean checksum);
+ void validatePerSSTableIndexComponents(IndexDescriptor indexDescriptor,
boolean checksum);
/**
* Validate all the per-column on-disk components and throw if a component
is not valid
*
* @param indexDescriptor The {@link IndexDescriptor} for the SSTable SAI
index
* @param indexContext The {@link IndexContext} holding the per-index
information for the index
* @param checksum {@code true} if the checksum should be tested as part
of the validation
- *
- * @return true if all the per-column components are valid
*/
- boolean validatePerColumnIndexComponents(IndexDescriptor indexDescriptor,
IndexContext indexContext, boolean checksum);
-
+ void validatePerColumnIndexComponents(IndexDescriptor indexDescriptor,
IndexContext indexContext, boolean checksum);
+
Review Comment:
nit: empty space.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
